Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): temporarily disable toc heading autoscrolling #6748

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 23, 2022

Motivation

This change (#6317) led to issues, for which we don't have a perfect solution yet.

Let's disable this temporarily so that next release does not have the bugs, we'll reapply it properly later.

See

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview, basic revert

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 23, 2022
@netlify
Copy link

netlify bot commented Feb 23, 2022

✔️ [V2]

🔨 Explore the source changes: ec87470

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62165b987d4df00007fe06ec

😎 Browse the preview: https://deploy-preview-6748--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6748--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -36 B (0%)

Total Size: 782 kB

Filename Size Change
website/build/assets/js/main.********.js 591 kB -36 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 48 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 37.6 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] scroll-behavior: smooth not working together with TOC anchor nav in 2.0.0-beta.15
3 participants