Skip to content

build arch-specific binaries for macOS in addition to the universal binary#48

Closed
bolinfest wants to merge 1 commit intofacebook:mainfrom
bolinfest:pr48
Closed

build arch-specific binaries for macOS in addition to the universal binary#48
bolinfest wants to merge 1 commit intofacebook:mainfrom
bolinfest:pr48

Conversation

@bolinfest
Copy link
Copy Markdown
Contributor

@bolinfest bolinfest commented Apr 18, 2025

I believe this should fix #47.

@bolinfest
Copy link
Copy Markdown
Contributor Author

@bigfootjon any concerns on this one?

@bolinfest
Copy link
Copy Markdown
Contributor Author

Hmm, though I suppose I should also update this as part of this PR:

:::note
On macOS, we **strongly** recommend running DotSlash as a
[Universal Binary](https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary)
rather than an x86 or ARM64 binary. If an x86 binary is running under
[Rosetta](https://developer.apple.com/documentation/apple-silicon/about-the-rosetta-translation-environment)
on Apple Silicon and ends up spawning `dotslash`, then for consistency with the
parent process, this will ensure that the `macos-x86_64` artifact will be run.
:::

@zertosh do you have any concerns with changing the guidance?

@bigfootjon
Copy link
Copy Markdown
Member

I think guidance is fine as-is, we can change it if users find that it isn't actually the case. Sorry for the slow action on this, I was on recharge

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@bigfootjon merged this pull request in 911cee3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: Why is the macos binary a universal binary?

3 participants