build arch-specific binaries for macOS in addition to the universal binary#48
Closed
bolinfest wants to merge 1 commit intofacebook:mainfrom
Closed
build arch-specific binaries for macOS in addition to the universal binary#48bolinfest wants to merge 1 commit intofacebook:mainfrom
bolinfest wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
@bigfootjon any concerns on this one? |
Contributor
Author
|
Hmm, though I suppose I should also update this as part of this PR: dotslash/website/docs/installation.md Lines 9 to 18 in 3345dc9 @zertosh do you have any concerns with changing the guidance? |
Member
|
I think guidance is fine as-is, we can change it if users find that it isn't actually the case. Sorry for the slow action on this, I was on recharge |
Contributor
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@bigfootjon merged this pull request in 911cee3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should fix #47.