feat: create npm package#74
Conversation
7fcc96b to
3c58349
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D79818880. (Because this pull request was imported automatically, there will not be any future comments.) |
b0be96d to
db5d091
Compare
|
Publishing as this is reasonably ready for review. In addition to reviewing, I'll need a maintainer to:
We should then update all references to As a heads up, my team will start using this npm package (published manually as |
|
cc @bigfootjon |
lets do
First step is to add |
Summary: Closes facebook#50. - [x] Basic structure of the package - [x] Publish under a temporary name ([`motizilberman/dotslash`](https://www.npmjs.com/package/motizilberman/dotslash)) - Done using `npm run build -- --version 0.5.7 --prerelease` - [x] Test on all platforms - [x] Iterate on README and test the workflows described there - [x] Add docs - [x] Set up GitHub Action for publishing to npm on every release - [x] Add Flow and TypeScript definition files for convenience - [x] Decide on a final package name and publish a non-prerelease version - ~We can either ask npm nicely to free up `dotslash` - currently unavailable because of [`dot-slash`](https://www.npmjs.com/package/dot-slash), a package last published 10 years ago with 5 weekly downloads - or go with e.g. `fb-dotslash` (which I have [reserved](https://www.npmjs.com/package/fb-dotslash)).~ - --> `fb-dotslash` - [x] Transfer package to Meta - --> added `fb` as a maintainer Possible follow-up scope (definitely not in this PR): - Add an *optional* postinstall script that replaces `bin/dotslash` with a symlink to the correct binary, thus making DotSlash'd tools start even faster in environments that respect postinstall scripts. ## How to publish the package ``` cd node npm ci npm run lint npm run build -- --version $RELEASED_DOTSLASH_VERSION # add --prerelease for testing npm publish ``` Differential Revision: D79818880 Pulled By: motiz88
a084a56 to
766fc19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79818880 |
|
@bigfootjon: I've implemented the requested changes and fixed lint errors. I've also created a test branch and tag on |
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
I've now set up the npm token as a secret in this repo, updated my test branch and pushed a new test tag --> the package got published correctly:
This should therefore be safe to merge, and will take effect from the next release of DotSlash. |
Closes #50.
@motizilberman/dotslash)npm run build -- --version 0.5.7 --prereleaseWe can either ask npm nicely to free updotslash- currently unavailable because ofdot-slash, a package last published 10 years ago with 5 weekly downloads - or go with e.g.fb-dotslash(which I have reserved).fb-dotslashfbas a maintainerPossible follow-up scope (definitely not in this PR):
bin/dotslashwith a symlink to the correct binary, thus making DotSlash'd tools start even faster in environments that respect postinstall scripts.How to publish the package