Skip to content

Handle unexpected end of JSON input for exceptions #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmtakf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle unexpected end of JSON input for exceptions #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/exceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,15 @@ function constructErrorResponse(response: Object) {

if (isBatchResponse) {
// Handle batch response
body =
typeof response.body === 'string'
? JSON.parse(response.body)
: response.body;
if (typeof response.body === "string") {
try {
body = JSON.parse(response.body);
} catch (_jsonParseError) {
body = response.body;
}
} else {
body = response.body;
}
status = response.code;
message = body.error.message;
headers = response.headers;
Expand All @@ -76,7 +81,15 @@ function constructErrorResponse(response: Object) {
// The request was made and the server responded with a status code
// that falls out of the range of 2xx
body = response.response.data.error ? response.response.data.error : response.response.data;
body = typeof body === 'string' ? JSON.parse(body) : body;
if (typeof body === "string") {
try {
body = JSON.parse(body);
} catch (_jsonParseError) {
body = body;
}
} else {
body = body;
}
message = body.message;
status = response.response.status;
headers = response.response.headers;
Expand Down