Skip to content

modify videoUploader/VideoEncodingStatusChecker #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alan0x wants to merge 2 commits into
base: main
Choose a base branch
from
Open

modify videoUploader/VideoEncodingStatusChecker #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c151ba0
modify videoUploader/VideoEncodingStatusChecker
infinite-yy Jun 27, 2018
c02b310
update
infinite-yy Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/objects/ad-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default class AdVideo extends AbstractCrudObject {
throw Error('Invalid Video ID');
}

VideoEncodingStatusChecker.waitUntilReady(
return VideoEncodingStatusChecker.waitUntilReady(
this.getApi(),
this['id'],
interval,
Expand Down
8 changes: 5 additions & 3 deletions src/video-uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,8 @@ class VideoEncodingStatusChecker {
let status = null;

while (true) {
status = VideoEncodingStatusChecker.getStatus(api, videoId);
status = status['video_status'];
status = await VideoEncodingStatusChecker.getStatus(api, videoId);
status = status['status']['video_status'];

if (status !== 'processing') {
break;
Expand All @@ -444,13 +444,15 @@ class VideoEncodingStatusChecker {

if (status !== 'ready') {
throw Error(`Video encoding status ${status}`);
}else{
return status
}
}

static getStatus (api: FacebookAdsApi, videoId: Number) {
const result = api.call('GET', [parseInt(videoId)], {fields: 'status'});

return result['status'];
return result;
}
}

Expand Down