Skip to content

[Accton][minipack3bta] Gate ACL byte counters by ASIC capability - #1533

Open
jenna-kuo wants to merge 1 commit into
facebook:mainfrom
jenna-kuo:fix-tu1-acl-byte-counter-capability
Open

[Accton][minipack3bta] Gate ACL byte counters by ASIC capability#1533
jenna-kuo wants to merge 1 commit into
facebook:mainfrom
jenna-kuo:fix-tu1-acl-byte-counter-capability

Conversation

@jenna-kuo

@jenna-kuo jenna-kuo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

  • Configure ACL counters according to the ASIC ACL_BYTE_COUNTER capability.
  • Use packet-only counters where byte counters are unsupported, while retaining packet and byte coverage on capable ASICs.
  • Gate byte-stat reads and the counter-type transition test to avoid unsupported SAI operations.

Test Plan

PASS on minipack3bta (TU1):

Cold boot:

  • cold_boot.AgentL4DstPortAclCounterTest.VerifyCounterBumpOnL4DstportHitFrontPanel
  • cold_boot.AgentAclTableGroupTest.AddTwoTablesDeleteFirst
  • cold_boot.AgentAclTableGroupTest.AddTwoTablesDeleteAddFirst
  • cold_boot.AgentAclTableGroupTest.AddTwoTablesDeleteAddSecond
  • cold_boot.AgentAclTableGroupTest.AddFirstTableAfterWarmboot
  • cold_boot.AgentAclTableGroupTest.DeleteFirstTableAfterWarmboot
  • cold_boot.AgentAclTableGroupTest.DeleteSecondTableAfterWarmboot
  • cold_boot.AgentAclTableGroupTest.RemoveAclEntriesFromAclTablesPostWarmboot
  • cold_boot.AgentAclCounterTest.VerifyCounterBumpOnSportHit
  • cold_boot.AgentAclCounterTest.VerifyCounterBumpOnSportHitWithDrop

Warm boot:

  • warm_boot.AgentL4DstPortAclCounterTest.VerifyCounterBumpOnL4DstportHitFrontPanel
  • warm_boot.AgentAclTableGroupTest.AddTwoTablesDeleteFirst
  • warm_boot.AgentAclTableGroupTest.AddTwoTablesDeleteAddFirst
  • warm_boot.AgentAclTableGroupTest.AddTwoTablesDeleteAddSecond
  • warm_boot.AgentAclTableGroupTest.AddFirstTableAfterWarmboot
  • warm_boot.AgentAclTableGroupTest.DeleteFirstTableAfterWarmboot
  • warm_boot.AgentAclTableGroupTest.DeleteSecondTableAfterWarmboot
  • warm_boot.AgentAclTableGroupTest.RemoveAclEntriesFromAclTablesPostWarmboot
  • warm_boot.AgentAclCounterTest.VerifyCounterBumpOnSportHit
  • warm_boot.AgentAclCounterTest.VerifyCounterBumpOnSportHitWithDrop

log: t1_agent_20260819_191209_.zip

@jenna-kuo
jenna-kuo requested a review from a team as a code owner August 19, 2026 11:24
@meta-cla meta-cla Bot added the CLA Signed label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant