[Nexthop][qsfp_service] Support AOC modules in the qsfp hw test media checks - #1535
Open
zackary-nexthop wants to merge 1 commit into
Open
[Nexthop][qsfp_service] Support AOC modules in the qsfp hw test media checks#1535zackary-nexthop wants to merge 1 commit into
zackary-nexthop wants to merge 1 commit into
Conversation
…checks Signed-off-by: Zackary Ayoun <zackary@nexthop.ai>
zackary-nexthop
force-pushed
the
zackary-nexthop.qsfp-service.test-aoc
branch
from
August 20, 2026 13:54
b5717d1 to
076bc35
Compare
harshitgulati18
approved these changes
Aug 20, 2026
Contributor
|
@harshitgulati18 has imported this pull request. If you are a Meta employee, you can view this in D116790437. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
AOCs report ACTIVE_CABLES with an OPTICAL transmitter and publish
activeCuCode, so the media compliance checks either crashed reading
smfCode or failed the COPPER transmitter assert on AOC ports.
Make the test expectations AOC-aware instead:
verifyActiveOpticalCableProfile, which checks activeCuCode and the
media interface code against the CmisHelper tables the product
programs active cables from.
assembly (DAC, AEC, or AOC).
Test code only; product code unchanged.
Test Plan
Full t0 and t1 qsfp suites with a locally built qsfp_hw_test:
Zero failures, zero skips. The previously failing AOC cases
(HwStateMachineTest.*, resetTranscieverAndDetectStateChanged,
i2cUniqueSerialNumbers) pass cold and warm boot; optics and DAC paths
are unchanged.