Skip to content

[Nexthop][qsfp_service] Support AOC modules in the qsfp hw test media checks - #1535

Open
zackary-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:zackary-nexthop.qsfp-service.test-aoc
Open

[Nexthop][qsfp_service] Support AOC modules in the qsfp hw test media checks#1535
zackary-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:zackary-nexthop.qsfp-service.test-aoc

Conversation

@zackary-nexthop

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

AOCs report ACTIVE_CABLES with an OPTICAL transmitter and publish
activeCuCode, so the media compliance checks either crashed reading
smfCode or failed the COPPER transmitter assert on AOC ports.

Make the test expectations AOC-aware instead:

  • New HwTransceiverUtils::isAoc routes AOC ports to
    verifyActiveOpticalCableProfile, which checks activeCuCode and the
    media interface code against the CmisHelper tables the product
    programs active cables from.
  • i2cUniqueSerialNumbers accepts AOCs: duplicate serials mean one cable
    assembly (DAC, AEC, or AOC).

Test code only; product code unchanged.

Test Plan

Full t0 and t1 qsfp suites with a locally built qsfp_hw_test:

platform modules t0 t1
m4062nhp 17x 800G AOC PASS 7/7 PASS 14/14
wedge800cact FR4 optics PASS 7/7 PASS 14/14
nh4010f 7x 800G DAC + 2x 800G AOC PASS 7/7 PASS 14/14

Zero failures, zero skips. The previously failing AOC cases
(HwStateMachineTest.*, resetTranscieverAndDetectStateChanged,
i2cUniqueSerialNumbers) pass cold and warm boot; optics and DAC paths
are unchanged.

@zackary-nexthop
zackary-nexthop requested review from a team as code owners August 19, 2026 20:31
@meta-cla meta-cla Bot added the CLA Signed label Aug 19, 2026
…checks

Signed-off-by: Zackary Ayoun <zackary@nexthop.ai>
@zackary-nexthop
zackary-nexthop force-pushed the zackary-nexthop.qsfp-service.test-aoc branch from b5717d1 to 076bc35 Compare August 20, 2026 13:54
@meta-codesync

meta-codesync Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@harshitgulati18 has imported this pull request. If you are a Meta employee, you can view this in D116790437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants