[Cisco] Fix FBOSS mirror DSCP encoding - #1537
Open
peterpiao27 wants to merge 1 commit into
Open
Conversation
Description: - The HW agent passed the 6-bit DSCP directly to the SAI 8-bit TOS field, causing incorrect packet DSCP. Solution: - Convert DSCP to TOS using DSCP << 2 for sFlow and ERSPAN mirrors. - Update mirror verification tests. Test Status: - Passed fboss-forwarding-stack build. - SAI replay verified TOS 168 for configured DSCP 42. - sFlow mirror is active. - sFlow packet DSCP is correct.
peterpiao27
marked this pull request as ready for review
August 20, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
FBOSS passed the configured 6-bit mirror DSCP directly to the SAI 8-bit TOS attribute. This caused DSCP 42 to produce an on-wire DSCP of 10.
Convert DSCP to TOS using
DSCP << 2for sFlow and ERSPAN mirror sessions, and update the associated mirror verification tests.Test Plan
fboss-forwarding-stacksuccessfully.0xA8).0xA8, corresponding to DSCP 42 and ECN 0.