[Accton][minipack3n] Update SMB VRM voltage sensor thresholds - #1538
Open
brandonchuang wants to merge 1 commit into
Open
[Accton][minipack3n] Update SMB VRM voltage sensor thresholds#1538brandonchuang wants to merge 1 commit into
brandonchuang wants to merge 1 commit into
Conversation
Summary Update SMB VRM output voltage sensor thresholds for Minipack3n platform to widen the acceptable operating range based on latest hardware characterization data. Changes 1. **Threshold adjustments for SMB VRM voltage outputs (VRM1, VRM3, VRM8~VRM11):** - Raised `upperCriticalVal` slightly (e.g. 0.9935 → 1.01725, 0.88875 → 0.905375) - Lowered `minAlarmVal` (e.g. 0.722 → 0.6745, 0.64125 → 0.608) - Lowered `lowerCriticalVal` (e.g. 0.6315 → 0.56025, 0.55875 → 0.508875) 2. **Sensor rename:** - `SMB_VDD_T2_3_VRM_VOUT` → `SMB_VDD_T2_VRM_VOUT` (corrected naming on SMB_VRM5) Test Plan Ran the following commands on DUT and verified sensor readings are within updated thresholds: - `Sensor_service` - `Sensor_service_hw_test` - `sensor_service_client`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.........................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed
Summary
Update SMB VRM output voltage sensor thresholds for Minipack3n platform to widen the acceptable operating range based on latest hardware characterization data.
Changes
upperCriticalValslightly (e.g. 0.9935 → 1.01725, 0.88875 → 0.905375)minAlarmVal(e.g. 0.722 → 0.6745, 0.64125 → 0.608)lowerCriticalVal(e.g. 0.6315 → 0.56025, 0.55875 → 0.508875)SMB_VDD_T2_3_VRM_VOUT→SMB_VDD_T2_VRM_VOUT(corrected naming on SMB_VRM5)Test Plan
Ran the following commands on DUT and verified sensor readings are within updated thresholds:
Sensor_servicemp3n_sensor_service.txt
Sensor_service_hw_testmp3n_sensor_service_hw_test.txt
sensor_service_clientmp3n_sensor_service_client.txt