[Nexthop][fboss2-dev] Add hitless/warmboot/coldboot options for config reload - #1542
Open
benoit-nexthop wants to merge 1 commit into
Open
[Nexthop][fboss2-dev] Add hitless/warmboot/coldboot options for config reload#1542benoit-nexthop wants to merge 1 commit into
benoit-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: rtl-nexthop <rtl@nexthop.ai>
Contributor
Author
|
Original change by @rtl-nexthop |
joseph5wu
requested changes
Aug 22, 2026
joseph5wu
left a comment
joseph5wu
left a comment
Contributor
There was a problem hiding this comment.
Please don't remove cpp files from the targets without any reason.
Also should we also specify reload which service's config?
| fboss/agent/hw/sai/store/tests/UdfStoreTest.cpp | ||
| fboss/agent/hw/sai/store/tests/VlanStoreTest.cpp | ||
| fboss/agent/hw/sai/store/tests/WredStoreTest.cpp | ||
| fboss/agent/hw/sai/store/tests/UdfStoreTest.cpp |
Contributor
There was a problem hiding this comment.
Why this PR is trying to remove a bunch of cpp files?
| using ObjectArgType = std::monostate; | ||
| static void addCliArg(CLI::App& cmd, std::vector<std::string>& args) { | ||
| cmd.add_option( | ||
| "boot_type", |
Contributor
There was a problem hiding this comment.
Since now we can support config bgp, do we also need to consider specifying which service to reload their configs? Based on the implementation here, we can only support reload agent config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an ending token for
hitless|warmboot|coldbootto thefboss2-dev config reloadcommand, with hitless being the default (existing) behavior if unspecified. This allows loading an arbitrary agent config and reliably doing a cold agent restart using the new config.Test Plan
Added new unit tests.
Manually verified: