[m4062nhp] Name fan sensors by tray and rotor - #1546
Draft
anna-nexthop wants to merge 1 commit into
Draft
Conversation
sensor_service exposed FAN1_RPM..FAN16_RPM, one per hwmon channel, so the numbers were rotor-flat: FAN8_RPM was really tray-4-outer and FAN11_RPM tray-6-inner. A rotor failure therefore surfaced as a sensor name that maps to no fan a technician can point at on the chassis. Rename to FAN<tray>_INNER_RPM / FAN<tray>_OUTER_RPM. sysfsPath values are unchanged, so this is purely a naming change; the four PSU fan sensors are untouched. Signed-off-by: Anna Komarova <anna@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
sensor_service exposed FAN1_RPM..FAN16_RPM, one per hwmon channel, so the numbers were rotor-flat: FAN8_RPM was really tray-4-outer and FAN11_RPM tray-6-inner. A rotor failure therefore surfaced as a sensor name that maps to no fan a technician can point at on the chassis.
Rename to FAN_INNER_RPM / FAN_OUTER_RPM. sysfsPath values are unchanged, so this is purely a naming change; the four PSU fan sensors are untouched.
Test Plan
Verified on hardware