Skip to content

Added fw_util support for P2 icecube800banw #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arajeev-ARISTA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added fw_util support for P2 icecube800banw #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions fboss/platform/configs/icecube800banw/fw_util.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
{
"fwConfigs": {
"cpu_cpld": {
"upgrade": [
{
"commandType": "jam",
"jamArgs": {
"jamExtraArgs": [
"-aprogram",
"-fmarconi_cpu_cpld",
"-v"
]
}
}
],
"version": {
"versionType": "sysfs",
"path": "/run/devmap/inforoms/CPU_FPGA_INFO_ROM/fw_ver"
},
"priority": 2
},
"smb_fpga": {
"upgrade": [
{
Expand Down
11 changes: 11 additions & 0 deletions fboss/platform/firmware_onboarding/configs/icecube800banw/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
load("@fbcode_macros//build_defs:export_files.bzl", "export_file")

oncall("fboss_platform")

export_file(
name = "spec",
src = "spec.json",
visibility = [
"//fboss/platform/firmware_onboarding/...",
],
)
35 changes: 35 additions & 0 deletions fboss/platform/firmware_onboarding/configs/icecube800banw/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"spec_version": "1.0",

"platform": {
"name": "icecube800banw",
"silicon": [
{ "name": "TH6" }
]
},

"components": [
{
"name": "smb_fpga",
"platform_identifier": "icecube800banw",
"location": "Switch Main Board",
"display_location": "smb",
"field_replaceable": false,
"firmware": {
"priority": 1,
"shared_with_platforms": []
}
},
{
"name": "cpu_cpld",
"platform_identifier": "icecube800banw",
"location": "System Control Module",
"display_location": "scm",
"field_replaceable": true,
"firmware": {
"priority": 2,
"shared_with_platforms": []
}
}
]
}
1 change: 1 addition & 0 deletions fboss/platform/firmware_onboarding/validator/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ python_unittest(
network_access = network_access_utils.none(),
resources = {
"//fboss/platform/firmware_onboarding/configs/icecube800bc:spec": "tests/icecube800bc.json",
"//fboss/platform/firmware_onboarding/configs/icecube800banw:spec": "tests/icecube800banw.json",
},
deps = [":preflight"],
)
9 changes: 2 additions & 7 deletions fboss/platform/firmware_onboarding/validator/tests/test_canonical_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@
run_preflight,
)


_CANONICAL_PLATFORMS: list[str] = [
"icecube800bc",
]
_CANONICAL_PLATFORMS: list[str] = ["icecube800bc", "icecube800banw"]


class CanonicalExamplesTest(unittest.TestCase):
Expand Down Expand Up @@ -73,7 +70,5 @@ def test_each_canonical_spec_passes_preflight(self) -> None:
# stays in sync if new tiers (e.g. `[depcheck]`) are added.
hard = [e for e in errors if _is_hard_failure(e)]
self.assertEqual(
hard,
[],
f"{platform}/spec.json failed preflight: {errors}",
hard, [], f"{platform}/spec.json failed preflight: {errors}"
)
Loading