Darwin48V: Configure Aboot configuration on upgrade #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading to the official Aboot 7.5.3 version, existing fw_util scripts configure the aboot_conf section from the Aboot image. Since boot methods are built into the image, this is not an issue for Darwin. But for Darwin48V, the DMI_BOARD_NAME needs to be configured in order for dmidecode to show the right thing. In addition to the Darwin48V change, there is a change to the Darwin config to fix an issue where fw_util was not working with certain SPI chips. The issue was the and/or operators in the command did not contain parenthesis, so the chip type N25Q128..3E was being used unconditionally. Test Plan 1. Tested the upgrade on a Darwin48V system. Verified that after the upgrade, dmidecode -t 2 showed DARWIN48V. 2. Tested the upgrade on a Darwin system. Verified that after the upgrade, dmidecode -t 2 showed DARWIN. 3. Tested the upgrade on a Darwin system with a MX25L12805D SPI chip. Verified the upgrade succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to the official Aboot 7.5.3 version, existing fw_util scripts configure the aboot_conf section from the Aboot image. Since boot methods are built into the image, this is not an issue for Darwin. But for Darwin48V, the DMI_BOARD_NAME needs to be configured in order for dmidecode to show the right thing.
In addition to the Darwin48V change, there is a change to the Darwin config to fix an issue where fw_util was not working with certain SPI chips. The issue was the and/or operators in the command did not contain parenthesis, so the chip type N25Q128..3E was being used unconditionally.
Test Plan
Tested the upgrade on a Darwin48V system. Verified that after the upgrade, dmidecode -t 2 showed DARWIN48V.
Tested the upgrade on a Darwin system. Verified that after the upgrade, dmidecode -t 2 showed DARWIN.
Tested the upgrade on a Darwin system with a MX25L12805D SPI chip. Verified the upgrade succeeded.