Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meru config updates: Update inforoms, add NVMEs, remove SCM VRMs #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Meru config updates: Update inforoms, add NVMEs, remove SCM VRMs #354

wants to merge 1 commit into from

Conversation

dzarista
Copy link

Updating all the meru configs:

meru800biab inforom offsets were out of date and are now updated.

SCM VRMs are no longer used - previously removed from sensor_service in this PR. #286 Now removed from platform_manager

Testing

No relevant platform_manager or sensor_service errors.

For all meru, in /run/devmap/sensors, NVME_TEMP is present and SCM VRMs are not.

ls -al NVME_TEMP
lrwxrwxrwx 1 root root 28 Mar 19 15:28 NVME_TEMP -> /sys/class/nvme/nvme0/hwmon0

ls -al SCM*
ls: cannot access 'SCM*': No such file or directory

@facebook-github-bot
Copy link
Contributor

Hi @dzarista!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@dzarista dzarista force-pushed the meru_configs branch 2 times, most recently from 77f15b0 to 374fed8 Compare March 19, 2025 16:26
@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dzarista has updated the pull request. You must reimport the pull request before landing.

@dzarista
Copy link
Author

@dzarista has updated the pull request. You must reimport the pull request before landing.

Rebased to resolve conflicts

@facebook-github-bot
Copy link
Contributor

@dzarista has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@dzarista has updated the pull request. You must reimport the pull request before landing.

@dzarista
standardize meru configs
22b5f94 
Revert "Merge branch 'main' into meru_configs"

This reverts commit 2bf7e52, reversing
changes made to 069c3f4.

fix merge markers

Revert "Revert "Merge branch 'main' into meru_configs""

This reverts commit 8da9f2c.
@facebook-github-bot
Copy link
Contributor

@dzarista has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzarista @facebook-github-bot