Darwin48V: Sync PM, led_manager, and weutil configs #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Platform manager
Port leds support
Added port leds support using scd-leds-darwin. Requires new bsp. See PR containing the new bsp changes for more details on testing.
Ensure write-protect (WP) is set prior to initializing the PSUs.
This is required for the pmbus kernel driver to initialize telemtry data on unsupported commands by the hardware. Enabling WP causes the driver to not consider the status register, which reports unsupported command errors, therefore preventing the issue where certain telemetry data points are omitted (in3_input, fan1_input, fan2_input.).
The default value of WP is enabled, however this issue arises when transitioning from an OS that utilizes a driver that disables WP. Therefore, the problem with the missing endpoints occurs and is only recovered manually or by powering off/on the PSUs.
Led manager config
No logical changes, config clean up.
Weutil config
Remove weutil support for fanspinner because it is not supported. This is because it lacks certain fields required by the Meta EEPROM format (namely, the Product Production State).