Janga: config: removed the prefix bp4f in platform config #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongedward
changed the title
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tao-ren
requested changes
Apr 23, 2025
Contributor
tao-ren
left a comment
tao-ren
left a comment
There was a problem hiding this comment.
@zhongedward can you please bump the BSP version to 3.0.0-1, the same with montblanc config?
Contributor
|
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
@tao-ren Ok, updated it.Please review, thanks. |
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@mikechoifb merged this pull request in 95d5718. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.This PR is for janga platform config file.Removed the prefix bp4f according to the github bsp new driver. Such as:
https://github.com/facebookexternal/fboss.bsp.celestica/commit/131720f68e486a1c77e05fe2d4c2f817bd4c9a57
2.According to this PR https://github.com/facebookexternal/fboss.bsp.celestica/pull/484,
we should change adm1272 to bp4f_adm1272.
Motivation
1.In the PR has changed
bp4f_mp9941--->mp9941
bp4f_mp2993--->mp2993
bp4f_mp2891--->mp2891
bp4f_xdpe12284--->xdpe12284
bp4f_xdpe15284--->xdpe15284
bp4f_tda38640--->tda38640
bp4f_max31790--->max31790
adm1272--->bp4f_adm1272
Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.Used jq cmd to pretty the format.
3.Test log as follows:
....
I1014 21:08:37.767549 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_41 to /dev/i2c-71. DevicePath: /[SMB_DOM_I2C_MASTER_41]
I1014 21:08:37.769764 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_42 to /dev/i2c-72. DevicePath: /[SMB_DOM_I2C_MASTER_42]
I1014 21:08:37.771961 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_43 to /dev/i2c-73. DevicePath: /[SMB_DOM_I2C_MASTER_43]
I1014 21:08:37.774213 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_44 to /dev/i2c-74. DevicePath: /[SMB_DOM_I2C_MASTER_44]
I1014 21:08:37.776411 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_45 to /dev/i2c-75. DevicePath: /[SMB_DOM_I2C_MASTER_45]
I1014 21:08:37.778622 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_46 to /dev/i2c-76. DevicePath: /[SMB_DOM_I2C_MASTER_46]
I1014 21:08:37.780858 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_5 to /dev/i2c-35. DevicePath: /[SMB_DOM_I2C_MASTER_5]
I1014 21:08:37.783096 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_6 to /dev/i2c-36. DevicePath: /[SMB_DOM_I2C_MASTER_6]
I1014 21:08:37.785289 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_7 to /dev/i2c-37. DevicePath: /[SMB_DOM_I2C_MASTER_7]
I1014 21:08:37.787502 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_8 to /dev/i2c-38. DevicePath: /[SMB_DOM_I2C_MASTER_8]
I1014 21:08:37.789696 11377 PlatformExplorer.cpp:688] Creating symlink from /run/devmap/xcvrs/xcvr_io_9 to /dev/i2c-39. DevicePath: /[SMB_DOM_I2C_MASTER_9]
I1014 21:08:37.793525 11377 PlatformExplorer.cpp:738] Reporting firmware version for JANGA_SMB_CPLD - version string:2.4.0
I1014 21:08:37.795091 11377 PlatformExplorer.cpp:738] Reporting firmware version for PWR_CPLD - version string:2.3.0
I1014 21:08:37.796548 11377 PlatformExplorer.cpp:738] Reporting firmware version for SMB_CPLD_1 - version string:2.4.0
I1014 21:08:37.796593 11377 PlatformExplorer.cpp:738] Reporting firmware version for SMB_DOM_INFO_ROM - version string:0.42
I1014 21:08:37.796625 11377 PlatformExplorer.cpp:738] Reporting firmware version for SMB_IOB_INFO_ROM - version string:0.51
I1014 21:08:37.796735 11377 PlatformExplorer.cpp:768] Reporting Production State: 4
I1014 21:08:37.796742 11377 PlatformExplorer.cpp:778] Reporting Production Sub-State: 5
I1014 21:08:37.796749 11377 PlatformExplorer.cpp:788] Reporting Variant Indicator: 20
I1014 21:08:37.796766 11377 ExplorationSummary.cpp:49] Successfully explored janga800bic...
W1014 21:08:37.796806 11377 Main.cpp:71] Skipping sd_notify since $NOTIFY_SOCKET is not set which does not imply systemd execution.
I1014 21:08:37.796811 11377 Main.cpp:78] Running PlatformManager thrift service...
I1014 21:08:37.797448 11377 ThriftServer.cpp:861] Using thread manager (resource pools not enabled) on address/port 5975: runtime: thriftFlagNotSet, , thrift flag: false, enable gflag: false, disable gflag: false
^C
[root@localhost edward]#
janga_platform_remove_bp4f_test_log_4_18.txt