[flow] Detect and ban cylic object type through prototype

Summary: Changelog: [errors] Bad cyclic object types are now banned. e.g. `type O_loop = { p: 0, __proto__: O_loop }` will cause an error.

Reviewed By: panagosg7

Differential Revision: D85918437

fbshipit-source-id: eef2ff4c8518d734d75ac437447d727b5d641d85

Author: SamChou19815

src/typing/flow_js_utils.ml

@@ -97,7 +97,6 @@ end = struct
         match t with
         (* composite types that allow self or cyclic reference *)
         | DefT (_, FunT _)
-        | DefT (_, ObjT _)
         | DefT (_, ArrT _)
         | DefT (_, InstanceT _)
         | DefT (_, ReactAbstractComponentT _)
@@ -108,6 +107,7 @@ end = struct
         | TypeAppT _
         | ThisTypeAppT _ ->
           acc
+        | DefT (_, ObjT { proto_t; _ }) -> super#type_ cx pole acc proto_t
         (* EvalT(t, d, _) behaves like TypeAppT, not everything there will be unconditionally
          * evaluated, but if we do have the eval result, we should visit it, since at that point,
          * the EvalT behaves like an OpenT. *)

tests/proto/proto.exp

@@ -210,6 +210,14 @@ References:
                             ^^^^^ [2]
 
 
+Error --------------------------------------------------------------------------------------------------- annot.js:35:34
+
+Invalid trivially recursive definition of prototype.  [recursive-definition]
+
+   35| type O_loop = { p: 0, __proto__: O_loop };
+                                        ^^^^^^
+
+
 Error ---------------------------------------------------------------------------------------------------- annot.js:37:2
 
 Cannot cast `o_loop.p` to empty because number literal `0` [1] is incompatible with empty [2]. [incompatible-type]
@@ -492,4 +500,4 @@ References:
 
 
 
-Found 34 errors
+Found 35 errors