[Flow] Replace nonexistent global ClientRect class with an alias to DOMRect #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OMRect Summary: Changelog: [fix] Replace incorrect definition for `ClientRect` and `ClientRectList` with aliases to `DOMRect` and `DOMRectList` This fixes the type definitions for the DOM APIs in Flow, but replacing an nonexistent globals `ClientRect` and `ClientRectList` types with just an alias to `DOMRect` and `DOMRectList`. Reviewed By: huntie Differential Revision: D70083998
|
This pull request was exported from Phabricator. Differential Revision: D70083998 |
|
This pull request was exported from Phabricator. Differential Revision: D70083998 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D70083998 |
|
This pull request has been merged in 8e56201. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [fix] Replace incorrect definition for
ClientRectandClientRectListwith aliases toDOMRectandDOMRectListThis fixes the type definitions for the DOM APIs in Flow, but replacing an nonexistent globals
ClientRectandClientRectListtypes with just an alias toDOMRectandDOMRectList.Reviewed By: huntie
Differential Revision: D70083998