[SH}CMake: use PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `CMAKE_SOURCE_DIR` contains the directory of the "root" CMakeLists.txt, but `PROJECT_SOURCE_DIR` contains the directory of the closest `project()` directive. Using the former is usually the wrong thing to do, if projects can be nested. Closes facebook#1678 Differential Revision: D73482392
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73482392 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
Summary: Pull Request resolved: #1679 `CMAKE_SOURCE_DIR` contains the directory of the "root" CMakeLists.txt, but `PROJECT_SOURCE_DIR` contains the directory of the closest `project()` directive. Using the former is usually the wrong thing to do, if projects can be nested. Closes #1678 Reviewed By: neildhar Differential Revision: D73482392 fbshipit-source-id: 94db57b186a378560d0508a880ebaa005122ca8f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CMAKE_SOURCE_DIRcontains the directory of the "root" CMakeLists.txt,but
PROJECT_SOURCE_DIRcontains the directory of the closestproject()directive. Using the former is usually the wrong thing todo, if projects can be nested.
Closes #1678
Differential Revision: D73482392