Rename jsi/hermes.h to jsi/hermes-interfaces.h #1843
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 17, 2025
Summary: Pull Request resolved: facebook#1843 X-link: facebook/react-native#54569 Differential Revision: D87200512
Summary: Pull Request resolved: facebook#1844 Pull Request resolved: facebook#1843 X-link: facebook/react-native#54569 Changelog: [Internal] Two "hermes.h" under different prefixes (jsi/hermes.h and hermes/hermes.h) are a bit confusing. Let's rename the JSI header to "hermes-interfaces.h". Differential Revision: D87200512
lavenzg
force-pushed
the
export-D87200512
branch
from
3895927 to
87361c2
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 19, 2025
Summary: Pull Request resolved: facebook#1844 Pull Request resolved: facebook#1843 X-link: facebook/react-native#54569 Changelog: [Internal] Two "hermes.h" under different prefixes (jsi/hermes.h and hermes/hermes.h) are a bit confusing. Let's rename the JSI header to "hermes-interfaces.h". Differential Revision: D87200512
lavenzg
added a commit
to lavenzg/react-native
that referenced
this pull request
Nov 19, 2025
Summary: X-link: facebook/hermes#1844 X-link: facebook/hermes#1843 Pull Request resolved: facebook#54569 Changelog: [Internal] Two "hermes.h" under different prefixes (jsi/hermes.h and hermes/hermes.h) are a bit confusing. Let's rename the JSI header to "hermes-interfaces.h". Differential Revision: D87200512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D87200512