Skip to content

Commit 9e4ddd3

Browse files
ottonimeta-codesync[bot]
authored andcommitted
Disable async JIT for profile translations when using ROAR
Summary: It causes a major regression still being investigated, so disable it for now. Reviewed By: mdko, jaewie Differential Revision: D95070001 fbshipit-source-id: 73ed203920348fde6c3da43168c46a7932a30197
1 parent 82e96d2 commit 9e4ddd3

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

hphp/doc/configs.specification

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ The format can be found in hphp/tools/configs/generate_configs.rs
719719

720720
- bool Eval.EnableAsyncJIT = false, UNKNOWN
721721
- bool Eval.EnableAsyncJITLive = false, arnabde
722-
- bool Eval.EnableAsyncJITProfile = true, UNKNOWN
722+
- bool Eval.EnableAsyncJITProfile, UNKNOWN
723723
- int Eval.AsyncJitWorkerThreads, UNKNOWN
724724

725725
- bool Eval.AsyncJitDeferContext = true, paulbiss

hphp/runtime/base/configs/eval-impl.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include "hphp/util/numa.h"
2626
#include "hphp/util/process-cpu.h"
2727
#include "hphp/util/ptr.h"
28+
#include "hphp/util/roar.h"
2829

2930
namespace HPHP::Cfg {
3031

@@ -151,4 +152,10 @@ int EvalLoader::AsyncJitWorkerThreadsDefault() {
151152
return std::max(4, Process::GetCPUCount() / 2);
152153
}
153154

155+
bool EvalLoader::EnableAsyncJITProfileDefault() {
156+
// Disabled with ROAR for now (T258073496).
157+
if (use_roar) return false;
158+
return true;
159+
}
160+
154161
}

0 commit comments

Comments
 (0)