Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aarch64] Remove -fsigned-char flag and fix resulting failure #7458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CMake/HPHPCompiler.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQU

# ARM64
if(IS_AARCH64)
# Force char type to be signed, which is not the case on aarch64.
list(APPEND GENERAL_OPTIONS "fsigned-char")

# If a CPU was specified, build a -mcpu option for the compiler.
set(CPU "" CACHE STRING "CPU to tell gcc to optimize for (-mcpu)")
if(CPU)
Expand Down
2 changes: 1 addition & 1 deletion hphp/runtime/ext/fileinfo/libmagic/apprentice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ file_signextend(struct magic_set *ms, struct magic *m, uint64_t v)
* the sign extension must have happened.
*/
case FILE_BYTE:
v = (char) v;
v = (signed char) v;
break;
case FILE_SHORT:
case FILE_BESHORT:
Expand Down