Fixes for building with icc. #7954
Conversation
| @@ -36,7 +36,7 @@ CHECK_CXX_SOURCE_COMPILES(" | |||
| int main() { return 0; }" IS_PPC64) | |||
|
|
|||
| # using Clang or GCC | |||
| if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU") | |||
| if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Intel") | |||
There was a problem hiding this comment.
You'll want to drop the other Intel section if it's no longer going to be used.
|
@gdbentley updated the pull request - view changes |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@Orvid this looks OK to me now, any objections to merging? |
| @@ -231,6 +231,7 @@ bool coerceFCallArgs(TypedValue* args, | |||
| * calling. | |||
| */ | |||
| template<bool usesDoubles> | |||
| __attribute__((noinline)) | |||
There was a problem hiding this comment.
Why is this changing? I would have thought changing how we inline callFunc could impact performance.
No description provided.