Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit xml output to test script #7966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gut
Copy link
Contributor

@gut gut commented Aug 18, 2017

Use hphp/test/run --xml to get an junit-like xml output. Useful on e.g
Jenkins as it can plot those results to a time series, so a regression
is easily spotted.

Use hphp/test/run --xml to get an junit-like xml output. Useful on e.g
Jenkins as it can plot those results to a time series, so a regression
is easily spotted.
@gut
Copy link
Contributor Author

gut commented Aug 18, 2017

@mxw or whoever can review this

@mxw mxw self-assigned this Aug 21, 2017
@fredemmott
Copy link
Contributor

Can you use a more generic format instead (eg Test Anything Protocol/TAP)? I don't like the idea of adding an option that's meant to emulate a tool that none of us use.

If there isn't a more tool-agnostic format that can be used instead, please rename the option to --junit-xml or similar, not just --xml, in case we have other needs in the future.

Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as my previous comment, if you stick with an XML-based format, use one of the built-in XML libraries instead of just concatenating/interpolating/printf'ing strings.

@gut
Copy link
Contributor Author

gut commented Aug 21, 2017

Ok, I'll take a closer look. Thanks for the hints

@mxw mxw assigned fredemmott and unassigned mxw Aug 21, 2017
@fredemmott fredemmott removed their assignment Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants