Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 - Update gdb python to use ARMv8 registers #7985

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swalk-cavium
Copy link
Contributor

This updates the register usage so these macros can be used on ARMv8 hosts.

@swalk-cavium
Copy link
Contributor Author

@mxw - Hi Max, Can you review? These changes allow the C++/PHP stack walk to work. Evidence below.

cat t | cut -c1-100
(gdb) walkstk
#0 {inline frame} @ 0x072b4148: HPHP::jit::tc::addrToOffset() at /mnt/cdn/hhvm/play.083017a/hhvm/hp
#1 0xffffffffced0 @ 0x072b4148: HPHP::jit::FixupMap::(anonymous namespace)::getFrameRegs() at /mnt/
#2 0xffffffffcf60 @ 0x072b45b8: HPHP::jit::FixupMap::fixupWork() at /mnt/cdn/hhvm/play.083017a/hhvm
#3 0xffffffffcfe0 @ 0x072b48a8: HPHP::jit::detail::syncVMRegsWork() at /mnt/cdn/hhvm/play.083017a/h
#4 0xffffffffd040 @ 0x063bef48: HPHP::jit::syncVMRegs() at /mnt/cdn/hhvm/play.083017a/hhvm/hphp/run
#5 0xffffffffd050 @ 0x063bef84: HPHP::VMRegAnchor::VMRegAnchor() at /mnt/cdn/hhvm/play.083017a/hhvm
#6 {inline frame} @ 0x05be1230: HPHP::ExecutionContext::invokeFuncImpl<HPHP::ExecutionContext::invo
#7 0xffffffffd070 @ 0x05be1230: HPHP::ExecutionContext::invokeFuncFew() at /mnt/cdn/hhvm/play.08301
#8 0xffffffffd1e0 @ 0x05c2b1f8: HPHP::ExecutionContext::invokeMethod() at /mnt/cdn/hhvm/play.083017
#9 0xffffffffd230 @ 0x05c2b254: HPHP::ExecutionContext::invokeMethodV() at /mnt/cdn/hhvm/play.08301
#10 {inline frame} @ 0x05c2b9e0: HPHP::invoke_destructor() at /mnt/cdn/hhvm/play.083017a/hhvm/hphp/r
#11 0xffffffffd290 @ 0x05c2b9e0: HPHP::ObjectData::destructImpl() at /mnt/cdn/hhvm/play.083017a/hhvm
#12 0xffffffffd3b0 @ 0x05c2c3c8: HPHP::ObjectData::releaseNoObjDestructCheck() at /mnt/cdn/hhvm/play
#13 0xffffffffd4c0 @ 0x05c2c878: HPHP::tail_call_remove_live_bc_obj() at /mnt/cdn/hhvm/play.083017a/
#14 0xffffffffd4e0 @ 0x05c2c920: HPHP::ObjectData::release() at /mnt/cdn/hhvm/play.083017a/hhvm/hphp
#15 0xffffacefff90 @ 0x14000228: [PHP] d::foo() at /mnt/cdn/hhvm/play.083017a/hhvm/hphp/test/quick/s
#16 0xffffacefffc0 @ 0x0f000954: [PHP] () at /mnt/cdn/hhvm/play.083017a/hhvm/hphp/test/q

@facebook-github-bot
Copy link
Contributor

@swalk-cavium updated the pull request - view changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants