Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 - Emit note if crc instructions available and not used #7987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swalk-cavium
Copy link
Contributor

The ability to use the ARMv8 crc instructions was added by PR#7556. They
are enabled only if an option is added to the cmake command line.

This makes a minor change to the HPHPCompiler.cmake file to emit a note
if the build host supports the crc instruction and it has not been selected.

@swalk-cavium
Copy link
Contributor Author

@mxw - Hi Max, Can you inspect?

@swalk-cavium
Copy link
Contributor Author

swalk-cavium commented Sep 6, 2017

@jim-saxman, @dave-estes, @cmuellnerTheobromaSystems - Any comments? It didn't seem right to change options automatically on the user, so I figured a note would be sufficient.

@jim-saxman
Copy link
Contributor

@swalk-cavium Works for me with our standard CMake command line. However, we're using the -DAARCH64_TARGET_CPU=qdf24xx in conjunction with the -DENABLE_AARCH64_CRC=1. Can I ask what your cmake looks like?

@swalk-cavium
Copy link
Contributor Author

@jim-saxman - I had been letting it default. That's when I noticed the one regression test slowing down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants