Syncing memcached.hhi with ext_memcached.php #7989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, assumed the spam/accidentla commennts were feedback requests. |
hhvm-bot
reviewed
Feb 22, 2018
There was a problem hiding this comment.
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hhvm-bot
approved these changes
Feb 23, 2018
There was a problem hiding this comment.
@fredemmott is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Reverted as it caused internal test issues, will investigate and re-land, but probably not today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #7950 by syncing the methods from ext_memcached.php to memcached.hhi
I also noticed there were also some strict-type inconsistencies in ext_memcached.php like: https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/memcached/ext_memcached.php#L341
But since this file appears to be auto-generated I didn't try to fix it there.