Update and fix bundled boost build#9574
Closed
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Since Boost is a C++ library dependency, we should force building its bundled version when building against libc++. Take this opportunity to update to a more recent Boost version, and use B2 options[1] to set the C++ version and toolchain from the superproject. Remove an outdated macOS patch that no longer applies. Add the chrono and date_time components to the list of components to build as they're needed by mvfst. [1] https://www.boost.org/doc/libs/1_87_0/tools/build/doc/html/index.html
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
This pull request has been merged in 75c1143. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Boost is a C++ library dependency, we should force building its bundled version when building against libc++.
Take this opportunity to update to a more recent Boost version, and use B2 options[1] to set the C++ version and toolchain from the superproject. Remove an outdated macOS patch that no longer applies.
Add the chrono and date_time components to the list of components to build as they're needed by mvfst.
Split from #9564.
[1] https://www.boost.org/doc/libs/1_87_0/tools/build/doc/html/index.html