Skip to content

Conversation

mszabo-wikia
Copy link
Contributor

@mszabo-wikia mszabo-wikia commented Jun 16, 2025

Address some straightforward test failures in HHVM OSS:

  • Gate tests for internal Meta extensions behind appropriate runif checks.
  • Set -vPHP7.EngineExceptions=false for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS.
  • Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242.
  • Remove a hardcoded fbcode reference.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

Address some straightforward test failures in HHVM OSS:

* Gate tests for internal Meta extensions behind appropriate runif
  checks.
* Set -vPHP7.EngineExceptions=false for some tests that assume this, as
  this knob defaults to false in internal builds but to true in OSS.
* Skip tests that exercise fb_(un)serialize() outside internal builds,
  since FBSerialize was removed from HHVM OSS in D46525242.
@mszabo-wikia mszabo-wikia force-pushed the fix-trivial-oss-test-failures branch from 97f0f9f to a15aff6 Compare October 6, 2025 11:11
@facebook-github-bot
Copy link
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants