Skip to content

Provide OCaml env vars for ocamlrep crate - #9635

Closed
mszabo-wikia wants to merge 1 commit into
facebook:masterfrom
mszabo-wikia:export-ocaml-env-to-rust
Closed

Provide OCaml env vars for ocamlrep crate#9635
mszabo-wikia wants to merge 1 commit into
facebook:masterfrom
mszabo-wikia:export-ocaml-env-to-rust

Conversation

@mszabo-wikia

Copy link
Copy Markdown
Contributor

build.rs in the ocamlrep crate expects a working OPAM env, so provide it in the setup file.

@meta-cla meta-cla Bot added the CLA Signed label Sep 24, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83145448. (Because this pull request was imported automatically, there will not be any future comments.)

@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 9a6662b to 12f44bd Compare October 6, 2025 10:59
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@meta-codesync

meta-codesync Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83145448. (Because this pull request was imported automatically, there will not be any future comments.)

@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 12f44bd to 9909d65 Compare October 6, 2025 11:11
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 9909d65 to 2096ee9 Compare December 3, 2025 22:29
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 2096ee9 to 61a5e56 Compare December 10, 2025 11:23
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@Wilfred

Wilfred commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

LGTM, just needs a rebase.

@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 61a5e56 to e092c12 Compare January 6, 2026 17:29
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

build.rs in the ocamlrep crate expects a working OPAM env,
so provide it in the setup file.
@mszabo-wikia
mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from e092c12 to f3ed850 Compare February 5, 2026 12:51
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@meta-codesync

meta-codesync Bot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been merged in b30eb7e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants