Fix macOS build for MemcpyBenchmark..cpp #9651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfi
added a commit
to mcfi/folly
that referenced
this pull request
Oct 13, 2025
Summary: X-link: facebook/hhvm#9651 sysconf on MacOS does not support _SC_LEVEL1_DCACHE_LINESIZE. We fix the build issue by just reading folly::hardware_destructive_interference_size, which is guaranteed to be a multiple of a cache line size. Note that we don't have to retrieve the accurate cache line size, just a multiple of its size is good enough. Differential Revision: D84522796
Summary: X-link: facebook/folly#2521 sysconf on MacOS does not support _SC_LEVEL1_DCACHE_LINESIZE. We fix the build issue by just reading folly::hardware_destructive_interference_size, which is guaranteed to be a multiple of a cache line size. Note that we don't have to retrieve the accurate cache line size, just a multiple of its size is good enough. Differential Revision: D84522796
mcfi
force-pushed
the
export-D84522796
branch
from
032d657 to
6e7c47c
Compare
meta-codesync bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 14, 2025
Summary: X-link: facebook/hhvm#9651 Pull Request resolved: #2521 sysconf on MacOS does not support _SC_LEVEL1_DCACHE_LINESIZE. We fix the build issue by just reading folly::hardware_destructive_interference_size, which is guaranteed to be a multiple of a cache line size. Note that we don't have to retrieve the accurate cache line size, just a multiple of its size is good enough. Reviewed By: yfeldblum Differential Revision: D84522796 fbshipit-source-id: 9a8b941d62f89d00b0b4eb9566bc3676d858300a
|
This pull request has been merged in a853722. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/folly#2521
sysconf on MacOS does not support _SC_LEVEL1_DCACHE_LINESIZE. We fix the build issue by just reading folly::hardware_destructive_interference_size, which is guaranteed to be a multiple of a cache line size. Note that we don't have to retrieve the accurate cache line size, just a multiple of its size is good enough.
Differential Revision: D84522796