Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Prevent insertion of link of collapsed selection #5346

Closed
wants to merge 15 commits into from
Closed

BugFix: Prevent insertion of link of collapsed selection #5346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d1f17d1
fix: added a check for discarding link intertion on collapsed selection
bhavyakaria Dec 6, 2023
139f01e
Merge remote-tracking branch 'origin/main' into bugfix/collapsed_sele…
bhavyakaria Dec 15, 2023
9c55b14
Merge remote-tracking branch 'origin/main' into bugfix/collapsed_sele…
bhavyakaria Dec 29, 2023
f2f799f
Merge remote-tracking branch 'origin/main' into bugfix/collapsed_sele…
bhavyakaria Apr 20, 2024
657f2bd
chore: fixed ut
bhavyakaria Apr 20, 2024
fef66f6
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Jun 14, 2024
7b4ec52
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Jun 24, 2024
ae08fc4
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
ivailop7 Jun 30, 2024
cbfb580
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Jul 3, 2024
81bb0ea
fix: return only if selection is empty
bhavyakaria Sep 6, 2024
b156285
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Sep 6, 2024
c072e0a
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Sep 7, 2024
4fb3b34
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Sep 19, 2024
8f937e8
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
bhavyakaria Sep 23, 2024
5b1ad86
Merge branch 'main' into bugfix/collapsed_selection_on_link_insertion
etrepum Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/lexical-link/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,9 @@ export function $toggleLink(
const {target, title} = attributes;
const rel = attributes.rel === undefined ? 'noreferrer' : attributes.rel;
const selection = $getSelection();
const selectionIsEmpty = selection && selection.isCollapsed() && url !== null;

if (!$isRangeSelection(selection)) {
if (!$isRangeSelection(selection) || selectionIsEmpty) {
return;
}
const nodes = selection.extract();
Expand Down
5 changes: 2 additions & 3 deletions packages/lexical-playground/__tests__/e2e/Links.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,7 +1440,8 @@ test.describe.parallel('Links', () => {
test('Can edit link with collapsed selection', async ({page}) => {
await focusEditor(page);
await page.keyboard.type('A link');
await selectAll(page);
await moveToLineBeginning(page);
await selectCharacters(page, 'right', 6);

await click(page, '.link');
await click(page, '.link-confirm');
Expand All @@ -1459,8 +1460,6 @@ test.describe.parallel('Links', () => {
</a>
</p>`,
);

await moveToLineBeginning(page);
await setURL(page, 'facebook.com');

await assertHTML(
Expand Down
Loading