-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-markdown] Refactor: Move Transformer Groups from index to MarkdownTransformers #6474
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @jkjk822! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
size-limit report 📦
|
Move transformer groups created in index.ts to MarkdownTransformers.ts, co-locating them with the member transformers and avoiding a cyclical dependency involving index.ts.
Co-authored-by: Lexical GitHub Actions Bot <>
…6367) Co-authored-by: Bob Ippolito <[email protected]>
…tem to `false` instead of `undefined` (facebook#5978)
…rect macOS shortcut (facebook#6497)
Description
Move transformer groups created in
index.ts
toMarkdownTransformers.ts
. This feels cleaner as it co-locates them with the member transformers as well as avoiding a cyclical dependency involvingindex.ts
andMarkdownShortcut.ts
.Test plan
N/A, current tests pass, which should suffice.