-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table] Support for vertical cell writing #6545
Draft
ivailop7
wants to merge
19
commits into
facebook:main
Choose a base branch
from
ivailop7:writing_mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 23, 2024
size-limit report 📦
|
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
August 23, 2024 21:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4437
vertical_writing.mov
Mechanics:
Chaging the CSS attribute writing-mode to 'vertical-rl' or 'vertical-lr' makes the text direction vertical. Once the text is vertical, most people would center it, to make this work seamlessly, we need to convert the text alignment 'left' to 'bottom', 'center' to 'middle', right to 'top', etc. and apply on TableCell-level. I've updated the FORMAT_ELEMENT_COMMAND in a separate PR (#6582) so we don't have the TableCell coupled to the paragraph within.
if no writing-mode is defined - assume the default horizontal, if writing-mode is present validate only 'vertical-rl' and 'vertical-lr' and ignore all the other deprecated properties as per https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode#values