Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Node replacement with withKlass example #6930

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Shopiley
Copy link
Contributor

@Shopiley Shopiley commented Dec 9, 2024

Description

This PR adds an editor example that uses Lexical's node replacement feature to the /examples directory in the repo. The plan is to make a stackblitz sandbox out of this for the node replacement doc.

Related to #6398

Test plan

Before

  • No example demonstrating the node replacement feature was present in the /examples directory.

After

  • A functional example demonstrating node replacement is available in the /examples directory.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:57pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:57pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size
lexical - cjs 31.18 KB (0%)
lexical - esm 31 KB (0%)
@lexical/rich-text - cjs 40.15 KB (0%)
@lexical/rich-text - esm 32.83 KB (0%)
@lexical/plain-text - cjs 38.79 KB (0%)
@lexical/plain-text - esm 30.15 KB (0%)
@lexical/react - cjs 42 KB (0%)
@lexical/react - esm 34.23 KB (0%)

@Shopiley Shopiley changed the title Feature: Node replacement with withKlass stackblitz example Feature: Node replacement with withKlass example Dec 10, 2024
@etrepum
Copy link
Collaborator

etrepum commented Dec 30, 2024

Are you planning to continue working on this PR, or should it be closed?

@Shopiley
Copy link
Contributor Author

Are you planning to continue working on this PR, or should it be closed?

Hi, yes I plan to continue. Got stuck over some lint errors but I’ll get back to it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants