Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Bug Fix Table Action Menu dropdown positioning #7229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lexical-playground] Bug Fix Table Action Menu dropdown positioning #7229

wants to merge 1 commit into from
+2 −2

Conversation

umaranis
Copy link
Contributor

Description

Table Action Menu is not positioned properly when the window is vertically scrolled.

Test plan

Before

Before.-.Table.Action.Menu.mov

After

After.-.Table.Action.Menu.mov

I have tested the following scenarios and they work fine after the fix:

  • when there is enough space below the Menu Button to display the Menu
  • when there is not enough space below the Menu Button but enough space above
  • when there is not enough space below and above the Menu Button
  • tested the above three scenarios when page is scrolled and not scrolled

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 11:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 11:25pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@etrepum etrepum added popover Issues related to popover/menu code in the playground extended-tests Run extended e2e tests on a PR labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR popover Issues related to popover/menu code in the playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umaranis @etrepum @facebook-github-bot