[lexical-playground] Feature: Create paragraphs around code#8072
Open
jvithlani wants to merge 5 commits intofacebook:mainfrom
Open
[lexical-playground] Feature: Create paragraphs around code#8072jvithlani wants to merge 5 commits intofacebook:mainfrom
jvithlani wants to merge 5 commits intofacebook:mainfrom
Conversation
jvithlani
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
Just added a new plugin, @etrepum let me know if this doesnt belong to playground folder |
Collaborator
|
It's fine to have it in the playground, but this implementation breaks the markdown view functionality which expects the editor to contain only a CodeNode. This plugin would have to be aware of that editor mode and disabled accordingly. |
jvithlani
force-pushed
the
create-paragraphs-around-code
branch
from
df8ea2d to
3f17056
Compare
Collaborator
|
You can run the e2e tests locally, have the playground running in one terminal with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that a paragraph node always exists before and after a code block. Currently, the absence of these nodes prevents the up and down arrow keys from functioning correctly. This change guarantees a "buffer" node (defaulting to a paragraph) to ensure consistent keyboard navigation.
Closes #7912
Before
Screen.Recording.2026-01-13.at.2.25.51.AM.mov
After
Screen.Recording.2026-01-13.at.2.19.46.AM.mov