[lexical-playground] Bug Fix: Code block formatting in unintended adjacent lines #8149
Open
achaljhawar wants to merge 3 commits intofacebook:mainfrom
Open
[lexical-playground] Bug Fix: Code block formatting in unintended adjacent lines #8149achaljhawar wants to merge 3 commits intofacebook:mainfrom
achaljhawar wants to merge 3 commits intofacebook:mainfrom
Conversation
achaljhawar
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
etrepum
reviewed
Feb 18, 2026
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
This PR should also include a test to confirm that the problem is fixed.
etrepum
reviewed
Feb 19, 2026
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
This does have the probably undesired effect of converting all LineBreakNode in the selection's blocks to new ParagraphNodes, rather than the ones inside or bordering the selection. Overall nice work!
etrepum
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code block formatting was pulling in unselected content after line breaks, this pr fixes this problem by splitting paragraphs at line break boundaries before conversion.
Closes #7691
Before
Lexical.Playground.4.mp4
After
Lexical.Playground.5.mp4