[lexical-rich-text] Bug Fix: Inherit format and style when inserting tab#8152
Open
kimseongyu wants to merge 1 commit intofacebook:mainfrom
Open
[lexical-rich-text] Bug Fix: Inherit format and style when inserting tab#8152kimseongyu wants to merge 1 commit intofacebook:mainfrom
kimseongyu wants to merge 1 commit intofacebook:mainfrom
Conversation
kimseongyu
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current Behavior
When inserting tabs within formatted text, the newly created TabNode does not inherit the existing format or style from the selection. So any text typed between tabs is plain text.
Change in This PR
When handling
INSERT_TAB_COMMAND, apply the selection's format and style to the new TabNode.Closes #8151
Test plan
Before
issue.mov
After
after.mov