Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bundling progress bar stuck at 100% #1445

Closed
wants to merge 1 commit into from
Closed

fix the bundling progress bar stuck at 100% #1445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/metro/src/lib/TerminalReporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,12 @@ class TerminalReporter {
}

/**
* We use Math.pow(ratio, 2) to as a conservative measure of progress because
* we know the `totalCount` is going to progressively increase as well. We
* also prevent the ratio from going backwards.
* Because we know the `totalFileCount` is going to progressively increase
* starting with 1:
* - We use Math.max(totalFileCount, 10) to prevent the ratio to raise too
* quickly when the total file count is low. (e.g 1/2 5/6)
* - We prevent the ratio from going backwards.
* - Instead, we use Math.pow(ratio, 2) to as a conservative measure of progress.
*/
_updateBundleProgress({
buildID,
Expand All @@ -373,9 +376,15 @@ class TerminalReporter {
if (currentProgress == null) {
return;
}
const rawRatio = transformedFileCount / totalFileCount;
const conservativeRatio = Math.pow(rawRatio, 2);
const ratio = Math.max(conservativeRatio, currentProgress.ratio);

const ratio = Math.min(
Math.max(
Math.pow(transformedFileCount / Math.max(totalFileCount, 10), 2),
currentProgress.ratio,
),
0.999, // make sure not to go above 99.9% to not get rounded to 100%,
);

Object.assign(currentProgress, {
ratio,
transformedFileCount,
Expand Down
Loading