Fix wildcard pattern precedence in package.json exports/imports resolution

packages/metro-resolver/src/__tests__/package-exports-test.js

@@ -510,16 +510,22 @@ describe('with package exports resolution enabled', () => {
             './features/bar/*.js': {
               'react-native': null,
             },
+            './node/*': './lib/node/*.js',
+            './*': './misc/*.js',
+            './node/*/types': './types/*/types.d.ts',
             './assets/*': './assets/*',
           },
         }),
+        '/root/node_modules/test-pkg/lib/node/test.js': '',
+        '/root/node_modules/test-pkg/lib/node/foo/public.js': '',
         '/root/node_modules/test-pkg/src/index.js': '',
         '/root/node_modules/test-pkg/src/features/foo.js': '',
         '/root/node_modules/test-pkg/src/features/foo.js.js': '',
         '/root/node_modules/test-pkg/src/features/bar/Bar.js': '',
         '/root/node_modules/test-pkg/src/features/baz.native.js': '',
         '/root/node_modules/test-pkg/src/features/node_modules/foo/index.js':
           '',
+        '/root/node_modules/test-pkg/types/foo/types.d.ts': '',
         '/root/node_modules/test-pkg/assets/Logo.js': '',
       }),
       originModulePath: '/root/src/main.js',
@@ -577,6 +583,32 @@ describe('with package exports resolution enabled', () => {
       `);
     });
 
+    test('should resolve prefixed wildcard export, using the most specific export path', () => {
+      const context = baseContext;
+
+      expect(Resolver.resolve(context, 'test-pkg/node/test', null)).toEqual({
+        type: 'sourceFile',
+        filePath: '/root/node_modules/test-pkg/lib/node/test.js',
+      });
+    });
+
+    test('longer patterns have higher specificity if bases are equal', () => {
+      const context = baseContext;
+      expect(
+        Resolver.resolve(context, 'test-pkg/node/foo/public', null),
+      ).toEqual({
+        type: 'sourceFile',
+        filePath: '/root/node_modules/test-pkg/lib/node/foo/public.js',
+      });
+
+      expect(
+        Resolver.resolve(context, 'test-pkg/node/foo/types', null),
+      ).toEqual({
+        type: 'sourceFile',
+        filePath: '/root/node_modules/test-pkg/types/foo/types.d.ts',
+      });
+    });
+
     describe('package encapsulation', () => {
       test('[nonstrict] should fall back to "browser" spec resolution and log inaccessible import warning', () => {
         const logWarning = jest.fn();

packages/metro-resolver/src/utils/matchSubpathFromExportsLike.js

@@ -55,12 +55,21 @@ export function matchSubpathFromExportsLike(
   // Attempt to match after expanding any subpath pattern keys
   if (target == null) {
     // Gather keys which are subpath patterns in descending order of specificity
+    // For ordering, see `PATTERN_KEY_COMPARE` in:
+    // https://nodejs.org/api/esm.html#resolution-algorithm-specification
     const expansionKeys = [...exportsLikeMapAfterConditions.keys()]
-      .filter(key => key.includes('*'))
-      .sort(key => key.split('*')[0].length)
-      .reverse();
+      .map(key => ({key, baseLength: key.indexOf('*')}))
+      .filter(data => data.baseLength !== -1)
+      .sort((a, b) => {
+        if (a.baseLength === b.baseLength) {
+          // If wildcards are in equal positions, the longer key is more
+          // specific
+          return b.key.length - a.key.length;
+        }
+        return b.baseLength - a.baseLength;
+      });
 
-    for (const key of expansionKeys) {
+    for (const {key} of expansionKeys) {
       const value = exportsLikeMapAfterConditions.get(key);
 
       // Skip invalid values (must include a single '*' or be `null`)