Releases: facebook/openbmc
Releases · facebook/openbmc
flashy-960593a
flashy: Add support for 128M fb-meta Summary: As title. This is to support platforms with larger flashes and images. Fixes oobgrader failure on gtartemis which has started to go beyond the 32M size. Test Plan: oobgrader on gtartemis which is 128M Flash. ``` oobgrader --host gtartemis-test-host -b openbmc.image.gtartemis:v2023.32.0 --flashy-tag 6746cb7 --wait <snip> <snip> c4746030-d209-4d88-b9de-18cee673c8f2 finished WorkflowStatus.FINISHED FinishStatus.SUCCEEDED ``` Workflow ID: c4746030-d209-4d88-b9de-18cee673c8f2 Ensure no regressions are observed in older ones. ``` oobgrader --host fby3-test-host -b openbmc.image.yosemite3:v2023.13.1 --flashy-tag 6746cb7 --wait <snip> <snip> b4524080-d79d-4ef2-a7e8-7fc97b224a0f finished WorkflowStatus.FINISHED FinishStatus.SUCCEEDED ``` Workflow ID: b4524080-d79d-4ef2-a7e8-7fc97b224a0f Reviewed By: cjcon90 Differential Revision: D48207387 fbshipit-source-id: f0f349b9ab237a439c8f0088da573cff141828b9
flashy-d67ca4c
fby35: halfdome: refine expected server type define Summary: # Description refine expected server type define, # Motivation to make the function more clean and readable. X-link: https://github.com/facebookexternal/openbmc.quanta/pull/4023 Test Plan: No function change Build OK on halfdome/fby35 Test on halfdome BMC connect with crater lake board `0 all 2023-07-31 19:21:33 gpiointrd Slot1 plugged in a wrong FRU ` Reviewed By: amithash Differential Revision: D47980164 fbshipit-source-id: 53b27ed979b017e8aa213ef81277bf8d58502c9e
flashy-c7f86a5
Use regexp for Flashy S356523 workaround
Summary:
When tested on an affected device with the built ephemeral fbpkg, the workaround in D47928352 did not catch the issue.
While the grep matches, it fails when used as a utils.runCommand
```
In [14]: await host.run_raw_cmd("grep mtd0:.*spi0.1 /proc/mtd")
Out[14]: CommandResult(exit_status=0, stderr='', stdout='mtd0: 08000000 00010000 "spi0.1"\n', exit_signal=None)
In [15]: await flashy.flashy_checks_and_remediations("flash1","grandteton","openbmc.image.grandteton:v2023.25.2",True)
Command '/run/flashy/checks_and_remediations/common/05_ensure_flash_writable --imagepath /run/upgrade/image --device mtd:flash1' exited with non-zero exit code: CommandResult(exit_status=53, std
err='2023/07/31 16:10:47 Starting: checks_and_remediations/common/05_ensure_flash_writable\n2023/07/31 16:10:47 Running command \'grep mtd0:.*spi0.1 /proc/mtd\' with 30s timeout\n2023/07/31 16:1
0:47 Command \'grep mtd0:.*spi0.1 /proc/mtd\' exited with code 1 after 6.668228ms\n2023/07/31 16:10:47 Running command \'fw_printenv bootargs\' with 30s timeout\n2023/07/31 16:10:47 stderr: Warn
ing: Bad CRC, using default environment\n2023/07/31 16:10:47 stdout: bootargs=console=ttyS0,57600n8 root=/dev/ram rw vmalloc=384M\n2023/07/31 16:10:47 Command \'fw_printenv bootargs\' exited wit
h code 0 after 17.899282ms\n2023/07/31 16:10:47 Running command \'fw_setenv _flashy_test 4d658221\' with 30s timeout\n2023/07/31 16:10:47 stderr: Warning: Bad CRC, using default environment\n202
3/07/31 16:10:47 Command \'fw_setenv _flashy_test 4d658221\' exited with code 0 after 30.450366ms\n2023/07/31 16:10:47 Running command \'fw_printenv _flashy_test\' with 30s timeout\n2023/07/31 1
6:10:47 stderr: Warning: Bad CRC, using default environment\n2023/07/31 16:10:47 stderr: ## Error: "_flashy_test" not defined\n2023/07/31 16:10:47 Command \'fw_printenv _flashy_test\' exited wit
h code 1 after 19.637594ms\n2023/07/31 16:10:47 U-Boot environment is READ ONLY\n2023/07/31 16:10:47 Running command \'fw_setenv _flashy_test\' with 30s timeout\n2023/07/31 16:10:47 stderr: Warn
ing: Bad CRC, using default environment\n2023/07/31 16:10:47 Command \'fw_setenv _flashy_test\' exited with code 0 after 30.213364ms\n2023/07/31 16:10:47 {Err:U-Boot environment is read only: fl
ash chips swapped? Error code: exit status 1, stderr: Warning: Bad CRC, using default environment\n## Error: "_flashy_test" not defined\n\ngithub.com/facebook/openbmc/tools/flashy/checks_and_rem
ediations/common.ensureFlashWritable\n\t/home/ciaranconcannon/local/openbmc/tools/flashy/checks_and_remediations/common/05_ensure_flash_writable.go:98\nmain.main\n\t/home/ciaranconcannon/local/o
penbmc/tools/flashy/flashy.go:139\nruntime.main\n\t/data/users/ciaranconcannon/gopaths/goroot/src/runtime/proc.go:250\nruntime.goexit\n\t/data/users/ciaranconcannon/gopaths/goroot/src/runtime/as
m_arm.s:824}\n{"message":"U-Boot environment is read only: flash chips swapped? Error code: exit status 1, stderr: Warning: Bad CRC, using default environment\\n## Error: \\"_flashy_test\\" not
defined\\n"}\n', stdout='', exit_signal=None)
FLASHY_ERROR_BAD_FLASH_CHIP: U-Boot environment is read only: flash chips swapped? Error code: exit status 1, stderr: Warning: Bad CRC, using default environment
## Error: "_flashy_test" not defined```
Test Plan:
Confirmed that flashy checks and remediations runs without issue with ephemeral built fbpkg openmbc.utils.flashy:414c5ac
```
In [2]: from openbmc.lib.openbmc_host import OpenBMCHost
In [3]: from openbmc.lib.helpers.flashy import Flashy
In [4]: host = OpenBMCHost("provisioninghold73583-oob.pci2")
In [5]: flashy = Flashy(host)
In [6]: await flashy.flashy_fetch("openbmc.image.grandteton:v2023.25.2")
In [7]: await flashy.flashy_install()
In [8]: await flashy.flashy_checks_and_remediations("flash1","grandteton","openbmc.image.grandteton:v2023.25.2",True)
In [9]:
```
---
Unit tests
```
$ go test .
ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/common
```
Reviewed By: mchugh19
Differential Revision: D47945711
fbshipit-source-id: 3d3c05c77b3d6cf85b687784f1357fd1c54204f1
flashy-d5b7671
Flashy workaround for GTT S356523 Summary: S356523 - checks and remediations are failing for any gtt running v2023.25.2 and above Test Plan: ``` $ go test . ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/common ``` Will look to build flashy ASAP and test against a previously failed host Reviewed By: lsiudut Differential Revision: D47928352 fbshipit-source-id: 2d654d4476d4ba15307a88d563c4d54b34b9ca7c
flashy-0334f04
Add flash procedure for inspirationpoint Summary: As title Test Plan: #doitlive Reviewed By: wangx6f Differential Revision: D46664901 fbshipit-source-id: 07450345e53f362efc5e89136666810b7af8632e
flashy-d84a405
fix unit tests in Sandcastle Summary: D46232899 fixed a unit test that was failing in CI. Unfortunately this breaks the same test in Sandcastle due to slightly a different error message from bash. Just remove the flaky test, because the very next test in the list does pretty much the same thing for us anyway. Test Plan: ``` 0 ~/local/openbmc/tools/flashy $ ./build.sh && ./build_dev.sh && go test ./... ok github.com/facebook/openbmc/tools/flashy (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/bletchley (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/common (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/galaxy100 (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/wedge100 (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/yamp (cached) ? github.com/facebook/openbmc/tools/flashy/flash_procedure [no test files] ok github.com/facebook/openbmc/tools/flashy/install (cached) ok github.com/facebook/openbmc/tools/flashy/lib/fileutils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashcp (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils/devices (cached) ? github.com/facebook/openbmc/tools/flashy/lib/logger [no test files] ok github.com/facebook/openbmc/tools/flashy/lib/step (cached) ok github.com/facebook/openbmc/tools/flashy/lib/utils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate/image (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate/partition (cached) ? github.com/facebook/openbmc/tools/flashy/tests [no test files] ? github.com/facebook/openbmc/tools/flashy/utilities [no test files] 0 ~/local/openbmc/tools/flashy $ ``` Reviewed By: mchugh19 Differential Revision: D46450604 fbshipit-source-id: e52594be601d410f936096471fd9595580a92f56
flashy-642eda5
ci: fix flashy tests (#220) Summary: Pull Request resolved: https://github.com/facebook/openbmc/pull/220 This test was failing in CI because the expected output was not what was actually being logged. It was just a simple miss and not indicative of any other problem so this just adjusts the expected result. Test Plan: CI Reviewed By: binhuang00 Differential Revision: D46232899 fbshipit-source-id: a1b7bd8059441e5cd6fb593218e04cafd3b502dd
flashy-39635b6
Flashy memtest Summary: Poor man's memtest. Sometimes BMC ram can be broken and this utility aims to alert on failing devices Test Plan: unit tests, run manually on a confirmed bad device Reviewed By: kawmarco fbshipit-source-id: 7424937251ea769f299e477a1df376d545adc8f5
flashy-8c63a38
add support for sandia Summary: - the factory build uses a different platform name - new flash procedure Test Plan: ``` 0 ~/local/openbmc/tools/flashy $ ./build.sh && ./build_dev.sh && go test ./... ok github.com/facebook/openbmc/tools/flashy 1.478s ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/common (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/galaxy100 (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/wedge100 (cached) ok github.com/facebook/openbmc/tools/flashy/checks_and_remediations/yamp (cached) ? github.com/facebook/openbmc/tools/flashy/flash_procedure [no test files] ok github.com/facebook/openbmc/tools/flashy/install 0.006s ok github.com/facebook/openbmc/tools/flashy/lib/fileutils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashcp (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/flash/flashutils/devices (cached) ? github.com/facebook/openbmc/tools/flashy/lib/logger [no test files] ok github.com/facebook/openbmc/tools/flashy/lib/step (cached) ok github.com/facebook/openbmc/tools/flashy/lib/utils (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate/image (cached) ok github.com/facebook/openbmc/tools/flashy/lib/validate/partition (cached) ? github.com/facebook/openbmc/tools/flashy/tests [no test files] ? github.com/facebook/openbmc/tools/flashy/utilities [no test files] 0 ~/local/openbmc/tools/flashy $ echo $? 0 ``` Reviewed By: kawmarco fbshipit-source-id: 6065d1537c512a88040d5f8fcc8d3b863b9fe9f9
qemux86-v2022.41.0
update process running test case for dhcpcd Summary: With D40090857 landed, ifupdown will start the dhcpcd with both IPv4 and IPv6. Update the Process Running test case. Test Plan: Build test with QEMU ``` root@bmc-oob:~# python3 /tmp/tests2/cit_runner.py -s /tmp/tests2 --platform grandcanyon -r tests.grandcanyon.test_process_running test_installed_processes (tests.grandcanyon.test_process_running.ProcessRunningTest) ... ok ---------------------------------------------------------------------- Ran 1 test in 0.220s OK ``` Reviewed By: doranand fbshipit-source-id: 522dd3567ab45c75932f47c09d95fef5a09cfbb2