Skip to content

Fix #3221: preserve dataclass field defaults in stubgen #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arths17 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix #3221: preserve dataclass field defaults in stubgen #3225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a6240e0
new file: perf/scale_test/README.md
Arths17 Apr 7, 2026
41d7ff4
modified: perf/scale_test/mock_org/__pycache__/analytics.cpython-31…
Arths17 Apr 7, 2026
1a9b680
Merge branch 'facebook:main' into main
Arths17 Apr 7, 2026
c3b94e8
Merge branch 'facebook:main' into main
Arths17 Apr 9, 2026
30103b5
Merge branch 'facebook:main' into main
Arths17 Apr 11, 2026
7f3e8eb
Merge branch 'facebook:main' into main
Arths17 Apr 16, 2026
ac7aeeb
Merge branch 'facebook:main' into main
Arths17 Apr 24, 2026
c24b206
Fix #3221: preserve dataclass field defaults in stubgen
Arths17 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions perf/scale_test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Mock Org Perf Suite

Generated synthetic Python modules for stressing import and type indexing.

Use generate_mock_org.py to regenerate this dataset.
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing multiple ~2K-line generated Python modules significantly increases repo size and can slow down clones, indexing, and CI steps that scan the tree. If the benchmark harness can generate these files at build/benchmark time, consider committing only the generator (and perhaps a small “golden” seed) rather than the full generated output; alternatively, document why committing the generated modules is required (determinism, offline runs, etc.) and consider keeping the generated set minimal.

Suggested change
Use generate_mock_org.py to regenerate this dataset.
The generated modules are checked in so the benchmark can run deterministically
and in offline environments without requiring a generation step during CI or
local performance runs.
Use `generate_mock_org.py` only when intentionally refreshing this dataset.
Keep the committed generated corpus minimal so repository size, clone time,
indexing, and CI tree scans stay as small as practical.

Copilot uses AI. Check for mistakes.
Loading
Loading