Fix undeclared loop variables in Pyrefly debugger#4240
Conversation
|
Hi @dhruvatr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Fixes #XXXX
Test Plan
Description
Declare loop variables explicitly in the Pyrefly debugger JavaScript code.
This change replaces implicitly created global variables with
constandletdeclarations in therender()andassertEq()functions.Changes
module_name,error, andbindingusingconst.iloop variable usinglet.kusingconst.This prevents accidental global variable creation and improves code safety and readability.