Remove unused symbol fields from pyrefly coverage#4250
Open
jorenham wants to merge 1 commit into
Open
Conversation
jorenham
added
the
coverage
This comment has been minimized.
This comment has been minimized.
jorenham
force-pushed
the
coverage/remove-unused-fields
branch
from
July 23, 2026 19:19
077f500 to
4b5afbd
Compare
Collaborator
Author
|
rebased to resolve conflicts |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some fields of
Function,Variable, andParameterwere set but never read, and since onlySymbolReportends up in the JSON output, theirSerializederives were also unused.This removes those fields and corresponding code, like the
is_fully_annotatedlogic and the annotation source-code lookups.Parameternow stores itsSlotRankdirectly, instead of two fields thatmerge_overloadsimmediately turned back into aSlotRank.Oh and don't forget to check the diff counts ;)
Test Plan
Tests still pass; no behavior changes