Fix semantic token highlighting for match captures#4257
Open
magic-akari wants to merge 1 commit into
Open
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
magic-akari
marked this pull request as ready for review
July 23, 2026 11:49
kinto0
requested changes
Jul 24, 2026
kinto0
left a comment
kinto0
left a comment
Contributor
There was a problem hiding this comment.
thanks for the PR! would you mind updating the summary with more details about the bug it fixed and maybe a screenshot of before / after? thanks!
kinto0
requested changes
Jul 24, 2026
| } | ||
|
|
||
| #[test] | ||
| fn pattern_capture_test() { |
Contributor
There was a problem hiding this comment.
do we need the test to be this big?
| Forward(Idx<Key>), | ||
| /// A definition boundary for a capture pattern. It forwards type information during solving, | ||
| /// but origin and definition lookups must not follow it through to the matched subject. | ||
| PatternCapture(Idx<Key>), |
Contributor
There was a problem hiding this comment.
can you help me understand why we need a new binding for this just for semantic tokens? why can't we handle this with the AST?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match capture patterns bind regular variables, but Pyrefly’s semantic-token walker only handled expression names. This caused capture definitions and some references to be missing or inconsistently highlighted.
This change:
variabletokens for all capture patterns.PatternCapturebinding that preserves the capture’s declaration identity.as, and OR patterns.Test Plan