3388 - Update analysis after uv sync - #4735
Conversation
|
Hi @savagecx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Hey @savagecx, thanks for working on this, it looks great! I just have one minor change to request around making the type a list, since I can see us adding more filetypes to watch to that in the future, and it'll make future updates a bit easier for us.
Once you're ready for another review, don't forget to request me up under the reviewers list! It's not too big of a change, so I'll probably pull it in and get it merged pretty quickly
| Self::PYPROJECT_FILE_NAME, | ||
| ]; | ||
|
|
||
| pub const UV_LOCK: &str = "uv.lock"; |
There was a problem hiding this comment.
Can we change this to an array slice (&[]) and rename it to ADDITIONAL_CRITICAL_FILES or something similar? I'm open to other names, but I can see us adding other filetypes here in the future!
|
This pull request has been imported. If you are a Meta employee, you can view this in D118606480. (Because this pull request was imported automatically, there will not be any future comments.) |
Summary
Adds the uv.lock file to the list of watched files so that running a uv sync initiates a file analysis.
Fixes #3388
Test Plan
Added an additional test to check that uv.lock is added to the watch list.
Ran test.py successfully.