website: allow yarn start without Mercurial - #4736
Conversation
docusaurus-plugin-internaldocs-fb 1.19.1 calls which.sync('hg')
without nothrow, so the public docs server crashes when hg is
missing. 1.19.2+ treats a missing binary as "not in an hg repo".
|
Hi @mangeshraut712! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
yarn startfor the public docs site crashed withError: not found: hgbecausedocusaurus-plugin-internaldocs-fb@1.19.1callswhich.sync('hg')without{ nothrow: true }. Thewhichpackage throws when the binary is missing, sohasHg()never returned false.1.19.2+ already passes
{ nothrow: true }, so a missinghgis treated as "not in a Mercurial repo." CI already builds the site without Mercurial; this makes the public dev server match that.Fixes #4612.
Changes
docusaurus-plugin-internaldocs-fbfrom^1.19.1to~1.19.3(resolved 1.19.3).~stays on 1.19.x and avoids 1.20.0's extra Docusaurus 2 mermaid dependency.website/README.md. Public website development does not require Mercurial.Testing
hg:yarn startfailed athasHg()in 1.19.1.yarn start --port 3001printedDocusaurus website is running at: http://localhost:3001/and compiled the client successfully.AI usage
An AI coding assistant was used under my direction to reproduce the crash, identify the
which.synccall in 1.19.1, and apply the version bump. I reviewed the plugin source and verifiedyarn startlocally.