[WIP] Proposal: coercible shape_extensions.Scalar - #4808
Draft
jakevdp wants to merge 1 commit into
Draft
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D118713401. (Because this pull request was imported automatically, there will not be any future comments.) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE – draft only
This PR is a draft/proposal for a new
shape_extensions.Scalartype that can be used to simplify APIs in NumPy and related libraries that allow scalars to be coerced into arrays.Currently, and API like
jax.numpy.addrequires multiple overloads to allow mixing of scalar and array values:This PR contains a proposed
shape_extensions.Scalarwhich allows this common pattern to be expressed much more succinctly:The
Scalartype defined here is specially recognized by pyrefly, and is only valid when its argument is an empty shape. This would allow libraries to compactly specify APIs which allow scalar inputs to be coerced to scalar arrays without the need for many overloaded signatures.This PR adds a proposed
Scalarimplementation, modifiesjax.numpy.addto make use of it, and adds a test to cover its intended semantics.A few open questions:
numpy.number? Perhaps the Scalar API should be something more general, likeScalar[Shape, int | float | complex]?Scalar[Shape]would admit arbitrary shapes in Python's general type system. Can we solve this a different way?