fix: TextInput onTextChanged triggered incorrectly #31376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
rnike
changed the title
Base commit: 91452fc |
Base commit: 91452fc |
|
It is amazing that we still cannot get |
sena-mike
reviewed
Jun 1, 2021
rnike
force-pushed
the
fix/30578/input-onchanged
branch
from
e6a6349 to
ce4c42a
Compare
|
Hoping this fix can be included in next release. |
rnike
force-pushed
the
fix/30578/input-onchanged
branch
from
ce4c42a to
b67c212
Compare
|
rebase to main for ci, but somehow the ci still failed |
rnike
force-pushed
the
fix/30578/input-onchanged
branch
from
b67c212 to
ea7cbb9
Compare
|
any updates on this PR? |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #30578
Using the language like Chinese, we need to construct a character with symbols or alphabets, the
onTextChangedfrom TextInput is not handling this kind of language correctly.Changelog
[iOS] [Fixed] - TextInput onTextChanged triggered incorrectly
Test Plan
Before
before.mov
After
after_applied.mov